container rm: suppress forced not found errors#7110
Merged
thaJeztah merged 1 commit intoJul 24, 2026
Conversation
HajimohammadiNet
marked this pull request as ready for review
July 17, 2026 13:55
thaJeztah
reviewed
Jul 24, 2026
| } else { | ||
| assert.NilError(t, err) | ||
| } | ||
| assert.Equal(t, cli.ErrBuffer().String(), tc.expectedStderr) |
Member
There was a problem hiding this comment.
tc.expectedStderr is never set, so probably can be removed, and this should just check if it's empty?
Contributor
Author
There was a problem hiding this comment.
Thanks, updated. I removed the unused table field and changed the test to assert stderr is empty directly.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: AmirHossein HajiMohammadi <[email protected]>
HajimohammadiNet
force-pushed
the
fix-container-rm-force-output
branch
from
July 24, 2026 14:09
9acb593 to
ee4c249
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixes #7076.
Suppresses stderr output for
docker rm --forcewhen the daemon reports that a container was not found. The command already treats that case as non-fatal; this makes the output match the successful exit status and the existingdocker network rm -fbehavior.- How I did it
Removed the stderr write in the
--force+ not-found branch, and added a regression assertion toTestRemoveForce.- How to verify it
./scripts/with-go-mod.sh go test ./cli/command/container- Human readable description for the release notes